andrew/alembic
1
0
Fork 0
Code Pull Requests Actions Releases 18 Wiki Activity

Background long-running actions; confirm destructive ones

Browse Source 
- Run now (jobs and playlists), dedup scan, genre preview/apply, and manual
  import now dispatch via BackgroundTasks and redirect immediately, instead
  of awaiting a job that can run for the better part of an hour and hang the
  browser or reverse proxy. Progress shows in the Jobs runs table (which
  already polls); if the pipeline is busy the run records skipped_lock there.
- Fix the import banner, which claimed work was ongoing after the request
  had actually blocked to completion; it now reflects the backgrounded start.
- Add confirmation prompts to the dedup per-row and bulk delete and to
  "Fix genres now", matching the existing confirms on library and playlist
  deletes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
andrew
2026-07-09 14:31:54 -06:00
parent b135f11557
commit 8f1fc458f6
8 changed files with 61 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/routers/genres.py
+9 -12
View File
@@ -1,4 +1,4 @@
from fastapi import APIRouter, Depends, Form, Request
from fastapi import APIRouter, BackgroundTasks, Depends, Form, Request
from fastapi.responses import RedirectResponse
from fastapi.templating import Jinja2Templates
from sqlalchemy import select
@@ -28,22 +28,19 @@ async def genres_index(request: Request, user: dict = Depends(require_auth), db=
@router.post("/scan")
async def scan(user: dict = Depends(require_auth)):
async def scan(background: BackgroundTasks, user: dict = Depends(require_auth)):
# Always force=True: matches the weekly scheduled run's own behavior
# (see genre_review_service.run's docstring), so a preview accurately
# shows what "Fix genres now" would actually do.
result = await genre_review_service.run(apply=False, force=True, triggered_by="manual")
if result is None:
return RedirectResponse(url="/genres?skipped=1", status_code=303)
return RedirectResponse(url="/genres", status_code=303)
# shows what "Fix genres now" would actually do. Runs in the background;
# the last-run table below fills in when it finishes.
background.add_task(genre_review_service.run, apply=False, force=True, triggered_by="manual")
return RedirectResponse(url="/genres?started=1", status_code=303)
@router.post("/apply")
async def apply(user: dict = Depends(require_auth)):
result = await genre_review_service.run(apply=True, force=True, triggered_by="manual")
if result is None:
return RedirectResponse(url="/genres?skipped=1", status_code=303)
return RedirectResponse(url="/genres", status_code=303)
async def apply(background: BackgroundTasks, user: dict = Depends(require_auth)):
background.add_task(genre_review_service.run, apply=True, force=True, triggered_by="manual")
return RedirectResponse(url="/genres?started=1", status_code=303)
@router.post("/lock")